Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the select_rolling_resample_op function #2017

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Expose the select_rolling_resample_op function #2017

merged 1 commit into from
Dec 10, 2024

Conversation

RondeauG
Copy link
Contributor

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • The function was added in Rolling statistics #1643, but I just realized that I forgot to expose it in the __all__. Thus, it does not appear anywhere in the xclim documentation.

Does this PR introduce a breaking change?

Other information:

@RondeauG RondeauG requested a review from Zeitsperre December 10, 2024 21:38
@github-actions github-actions bot added the approved Approved for additional tests label Dec 10, 2024
@Zeitsperre Zeitsperre added this to the v0.54.0 milestone Dec 10, 2024
@RondeauG RondeauG merged commit 8893780 into main Dec 10, 2024
31 checks passed
@RondeauG RondeauG deleted the expose_rolling_resample branch December 10, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees

@RondeauG RondeauG

Labels
approved Approved for additional tests
Projects
None yet
Milestone
v0.54.0
Development

Successfully merging this pull request may close these issues.
2 participants
@RondeauG @Zeitsperre