Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #311 and add keywords #334

Merged
merged 3 commits into from
Jan 7, 2020
Merged

Revert #311 and add keywords #334

merged 3 commits into from
Jan 7, 2020

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Jan 6, 2020

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated

After merging to master and before closing the branch:

  • bumpversion (minor / major / patch) has been called on master branch
  • Tags have been pushed
  • What kind of change does this PR introduce?

Reverts #311 as per conclusions of Ouranosinc/xclim-benchmark#1 and pydata/xarray#3161. All calls to _rolling(da, dim='dim', window=window, mode=mode) have been turned into calls to da.rolling(dim=window).mode(allow_lazy=True, skipna=False).

  • Does this PR introduce a breaking change?

No.

  • Other information:

When used with xarray 0.15, a bunch of deprecation warning will appear from the explicit allow_lazy=True.

This PR fixes #316.

@aulemahal aulemahal requested a review from huard January 6, 2020 22:21
@aulemahal aulemahal self-assigned this Jan 6, 2020
@aulemahal aulemahal added this to the v0.13 milestone Jan 6, 2020
@aulemahal aulemahal requested review from tlogan2000 and removed request for huard January 6, 2020 22:28
@coveralls
Copy link

coveralls commented Jan 6, 2020

Pull Request Test Coverage Report for Build 1430

  • 8 of 8 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 89.528%

Totals Coverage Status
Change from base Build 1428: -0.2%
Covered Lines: 3454
Relevant Lines: 3858

💛 - Coveralls

Copy link
Collaborator

@tlogan2000 tlogan2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on the benchmarking

@huard huard merged commit f661875 into master Jan 7, 2020
@huard huard deleted the revert-rolling-to-xr branch January 7, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark utils._rolling() versus xr.rolling(allow_lazy=True)
4 participants