Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
After merging to master and before closing the branch:
master
branchReverts #311 as per conclusions of Ouranosinc/xclim-benchmark#1 and pydata/xarray#3161. All calls to
_rolling(da, dim='dim', window=window, mode=mode)
have been turned into calls toda.rolling(dim=window).mode(allow_lazy=True, skipna=False)
.No.
When used with xarray 0.15, a bunch of deprecation warning will appear from the explicit
allow_lazy=True
.This PR fixes #316.