-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
修复Stfld与Ldfld当对象为适配器时的异常 #655
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liiir1985
requested changes
Feb 10, 2022
@@ -2105,9 +2105,13 @@ public object Run(ILMethod method, object instance, object[] p) | |||
|
|||
if (obj != null) | |||
{ | |||
if (obj is ILTypeInstance) | |||
ILTypeInstance instance = null; | |||
if (obj is ILTypeInstance ilTypeInstance) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请不要使用c# 7以上的语法,会导致老版本Unity无法使用,需要修改
ILTypeInstance instance = null; | ||
if (obj is ILTypeInstance ilTypeInstance) | ||
instance = ilTypeInstance; | ||
else if (obj is CrossBindingAdaptorType crossBindingAdaptorType) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
修改代码然后重新创建一个pull request么? |
直接在当前pr的分支上修改并提交即可 |
@liiir1985 修改已提交 |
liiir1985
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在测试用例源码文件
InheritanceTest.cs
中增加如下2个用例其中
InheritanceTest21
报如下异常原因为未处理局部变量
obj
为适配器类型(CrossBindingAdaptorType
)的情况用例
InheritanceTest22
同理