-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
修复跨域适配器生成代码的 bug #750
Open
m1stm4o
wants to merge
5
commits into
Ourpalm:master
Choose a base branch
from
m1stm4o:fix_adapter_generator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
修复跨域适配器生成代码的 bug #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liiir1985
requested changes
Mar 31, 2023
@@ -373,15 +373,6 @@ static string GetParametersTypeString(ParameterInfo[] param, Type returnType) | |||
if (isByRef) | |||
sb.Append(".MakeByRefType()"); | |||
} | |||
if (returnType != typeof(void)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
能否提供一个生成不正确的具体例子
@@ -531,7 +531,7 @@ static void GenerateCrossBindingMethodClass(StringBuilder sb, string funcName, i | |||
sb.AppendLine(" }"); | |||
if (hasReturn) | |||
sb.AppendLine(@" else | |||
return default(TResult);"); | |||
return default;"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unity2018以前的版本不支持default关键字,只支持default(T)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
代码库中很多代码需要生成适配器,触发了几个 bug,修复了一下