-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDEV-5995 Support for webpack 5 #151
Conversation
ViewGenerator/tools/webpack/Plugins/ForkTsCheckerWebpackFormatterPlugin.ts
Outdated
Show resolved
Hide resolved
@@ -1,84 +1,44 @@ | |||
import { basename } from "path"; | |||
import { RuleSetRule } from "webpack"; | |||
import { AssetInfo, NormalModule, PathData, RuleSetRule } from "webpack"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will these changes fix the hack we have on the framework to have the web components packages available in that project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which hack? 😅 the webview.plugins
symlink?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If so, I haven't changed that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to test this, I'm not convinced it will fix it..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I do not think it will fix it... But I have some ideas that we can leverage afterwards
@joaompneves I'll address your comments in another PR |
Upgrade webpack and its plugins from v4 to v5, and dealing with breaking changes.