Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNMT-3324 [InAppBrowser] In app browser doesn't open in iOS 13 #9

Merged
merged 13 commits into from
Oct 4, 2019

Conversation

usernuno
Copy link

@usernuno usernuno commented Oct 1, 2019

Description

Pulls changes from master of upstream. The latest commit is the important one.

Context

Closes https://outsystemsrd.atlassian.net/browse/RNMT-3324

Opening the InAppBrowser in iOS 13 would instantly close the newly created UIViewController.

Issue was opened in the upstream repository and a fix was approved and merged to master. All the changes between what we had and the master of upstream are:

All context can be found in those 2 links.

Type of changes

  • Feature (change which adds functionality)
    • BREAKING CHANGE (existing functionality will not work as expected due to new feature)
  • Fix (change which fixes an issue)
    • BREAKING CHANGE (existing functionality will not work as expected due to fix)
  • Performance (change which improves performance)
    • BREAKING CHANGE (existing functionality will not work as expected due to performance improvement)
  • Refactor (non-breaking change that is neither feature, fix nor performance)
  • Style (non-breaking change that only affects formatting and/or white-space)

Components affected

  • Android platform
  • iOS platform
  • JavaScript
  • OutSystems

Tests

Manually tested the fix.

Screenshots (if appropriate)

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Tests have been created
  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

NiklasMerz and others added 13 commits January 16, 2019 14:22
Avoid failed script injections for pages which did not finish loading.
Removed tmpWindow and controller.
This was introduced to fix IAB with WKWebView before WKIAB existed.
Fixes close, hide and toolbar 'done' and makes cordova window responsive
Fix inappbrowser not opening on iOS 13 by using reusable window. Resolves apache#492
Move bridge creation to injectDeferredObject
# Conflicts:
#	package.json
#	plugin.xml
#	tests/package.json
#	tests/plugin.xml
@usernuno usernuno self-assigned this Oct 1, 2019
@usernuno usernuno changed the title [InAppBrowser] In app browser doesn't open in iOS 13RNMT-3324 RNMT-3324 [InAppBrowser] In app browser doesn't open in iOS 13 Oct 1, 2019
@usernuno usernuno merged commit 4af3146 into outsystems Oct 4, 2019
@usernuno usernuno deleted the fix/RNMT-3324/does-not-open-in-ios13 branch October 4, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants