forked from apache/cordova-plugin-inappbrowser
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RNMT-3324 [InAppBrowser] In app browser doesn't open in iOS 13 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid failed script injections for pages which did not finish loading.
Removed tmpWindow and controller. This was introduced to fix IAB with WKWebView before WKIAB existed.
Fixes close, hide and toolbar 'done' and makes cordova window responsive
Fix inappbrowser not opening on iOS 13 by using reusable window. Resolves apache#492
Move bridge creation to injectDeferredObject
# Conflicts: # package.json # plugin.xml # tests/package.json # tests/plugin.xml
usernuno
requested review from
EiyuuZack,
Chuckytuh,
cmfsotelo,
vmfo22,
pmaroco and
luissilvaos
October 1, 2019 15:38
usernuno
changed the title
[InAppBrowser] In app browser doesn't open in iOS 13RNMT-3324
RNMT-3324 [InAppBrowser] In app browser doesn't open in iOS 13
Oct 1, 2019
luissilvaos
approved these changes
Oct 4, 2019
Chuckytuh
approved these changes
Oct 4, 2019
cmfsotelo
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pulls changes from master of upstream. The latest commit is the important one.
Context
Closes https://outsystemsrd.atlassian.net/browse/RNMT-3324
Opening the InAppBrowser in iOS 13 would instantly close the newly created UIViewController.
Issue was opened in the upstream repository and a fix was approved and merged to master. All the changes between what we had and the master of upstream are:
All context can be found in those 2 links.
Type of changes
Components affected
Tests
Manually tested the fix.
Screenshots (if appropriate)
Checklist
RNMT-XXXX <title>