Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-10900 Updated _showLoadingMessage to stop using inline styles #422

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

gnbm
Copy link
Collaborator

@gnbm gnbm commented Jun 30, 2024

This PR will update the framework method _showLoadingMessage to stop using inline styles.

What was happening

  • In O11, when dealing with platform settings related to CSP and unsafe-inline, we identified an improvement we could make in the framework.

What was done

  • Added the following CSS utility classes
  • Updated the framework method _showLoadingMessage to stop using inline styles and used the CSS utility classes mentioned above.
.full-size {
  width: 100%;
  height: 100%;
}

.ml-10 {
  margin-left: 10px;
}

Screenshot

image

Test Steps

  1. Go to a screen containing a Data Grid instance
  2. On the dev tool’s console run → OutSystems.GridAPI.GridManager.GetActiveGrid().features.export._showLoadingMessage()
  3. Check that the loading status continues to work as expected

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems
  • requires new sample page in OutSystems

@gnbm gnbm added improvement Can be of code or of a given feature. chore labels Jun 30, 2024
Copy link

@gnbm gnbm marked this pull request as ready for review July 1, 2024 16:54
@gnbm gnbm requested a review from a team as a code owner July 1, 2024 16:54
@gnbm gnbm merged commit 5bad0da into dev Jul 2, 2024
9 of 13 checks passed
@gnbm gnbm deleted the ROU-10900 branch July 2, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore improvement Can be of code or of a given feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants