Skip to content

Commit

Permalink
Merge branch 'dev' into ROU-4503
Browse files Browse the repository at this point in the history
  • Loading branch information
BenOsodrac authored Aug 29, 2023
2 parents 0906099 + 18173d2 commit 5399cc1
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 29 deletions.
3 changes: 3 additions & 0 deletions dist/OutSystemsUI.css
Original file line number Diff line number Diff line change
Expand Up @@ -11706,6 +11706,9 @@ html[data-uieditorversion^="1"] .osui-timepicker__dropdown-ss-preview.time12h, h
-webkit-perspective:1000px;
perspective:1000px;
}
.desktop .osui-tabs__content-item:not(.osui-tabs--is-active) *{
visibility:hidden;
}
.osui-tabs__preview{
display:none;
}
Expand Down
7 changes: 7 additions & 0 deletions src/scripts/OSFramework/OSUI/Pattern/Tabs/scss/_tabs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,13 @@
}
}

// Fix issue when patterns like Dropdown are open when the header click is triggered.
.desktop {
.osui-tabs__content-item:not(.osui-tabs--is-active) * {
visibility: hidden;
}
}

// Service Studio Preview Message
.osui-tabs__preview {
display: none;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,29 +42,10 @@ namespace Providers.OSUI.Dropdown.VirtualSelect {

// Manage the attributes to be added
private _manageAttributes(): void {
// Check if the pattern should be in disabled mode
this._manageDisableStatus();

// Manage A11Y attributes
this.setA11YProperties();
}

// Manage the disable status of the pattern
private _manageDisableStatus(): void {
if (this.configs.IsDisabled) {
OSFramework.OSUI.Helper.Dom.Attribute.Set(
this.selfElement,
OSFramework.OSUI.GlobalEnum.HTMLAttributes.Disabled,
''
);
} else {
OSFramework.OSUI.Helper.Dom.Attribute.Remove(
this.selfElement,
OSFramework.OSUI.GlobalEnum.HTMLAttributes.Disabled
);
}
}

// Prevent the default behaviour of the event
private _onMouseUp(event) {
event.preventDefault();
Expand Down Expand Up @@ -275,8 +256,6 @@ namespace Providers.OSUI.Dropdown.VirtualSelect {
if (this.isBuilt) {
switch (propertyName) {
case OSFramework.OSUI.Patterns.Dropdown.Enum.Properties.IsDisabled:
this._manageDisableStatus();
break;
case Enum.Properties.NoOptionsText:
case Enum.Properties.NoResultsText:
case Enum.Properties.OptionsList:
Expand Down Expand Up @@ -319,10 +298,9 @@ namespace Providers.OSUI.Dropdown.VirtualSelect {
* @memberof Providers.OSUI.Dropdown.VirtualSelect.AbstractVirtualSelect
*/
public disable(): void {
if (this.configs.IsDisabled === false) {
if (this.configs.IsDisabled === false && this.provider !== undefined) {
this.configs.IsDisabled = true;

this._manageDisableStatus();
this.provider.$ele.disable();
}
}

Expand Down Expand Up @@ -359,10 +337,9 @@ namespace Providers.OSUI.Dropdown.VirtualSelect {
* @memberof Providers.OSUI.Dropdown.VirtualSelect.AbstractVirtualSelect
*/
public enable(): void {
if (this.configs.IsDisabled) {
if (this.configs.IsDisabled && this.provider !== undefined) {
this.configs.IsDisabled = false;

this._manageDisableStatus();
this.provider.$ele.enable();
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ namespace Providers.OSUI.Dropdown.VirtualSelect {
// Set the library options
this._providerOptions = {
ele: this.ElementId,
disabled: this.IsDisabled,
dropboxWrapper: OSFramework.OSUI.GlobalEnum.HTMLElement.Body,
hasOptionDescription: hasDescription,
hideClearButton: false,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# VirtualSelect · ![virtualselect version](https://img.shields.io/badge/version-v1.0.39-informational)
# VirtualSelect · ![virtualselect version](https://img.shields.io/badge/version-v1.0.40-informational)

All info about this Provider <a href="https://sa-si-dev.github.io/virtual-select/#/">here</a>.
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,9 @@
position: relative;
}
.vscomp-search-label,
.vscomp-live-region {
.vscomp-live-region,
.vscomp-dropbox-container-top,
.vscomp-dropbox-container-bottom {
border: 0;
clip: rect(0 0 0 0);
height: 1px;
Expand Down

0 comments on commit 5399cc1

Please sign in to comment.