ROU-4327: Improve event management on remove handler #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenOsodrac
requested review from
gnbm,
joselrio,
bmarcelino-fe,
rugoncalves,
JoaoFerreira-FrontEnd and
OS-giulianasilva
as code owners
OS-giulianasilva
previously approved these changes
Jul 11, 2023
joselrio
requested changes
Jul 11, 2023
OS-giulianasilva
approved these changes
Jul 11, 2023
joselrio
approved these changes
Jul 11, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for improving the management of the events. This was found when improving the lifecycle of the orientationChange event (OutSystems code), that was not being added again in runtime, as the _events map wasn't correctly removing the eventType, when the last handler was removed.
Checklist