Custom Header and Response Status Check #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ReponseStatusFn to determine request status
OutdatedGuy
requested changes
Dec 20, 2023
There was a problem hiding this comment.
Yo @tatashidayat, thanks for this PR. It looks good on the logic and is working properly.
I just need a few necessary changes mentioned below.
|
Hi @tatashidayat, do you plan to follow up on this PR? |
|
Hi @OutdatedGuy, I haven't seen this PR for a while. Let me address some comments. |
* add doc on ResponseStatusFn typedef * add default responseStatusFn * add constructor header default value
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @OutdatedGuy,
I found that this package is awesome, but in my usecase I need custom headers and response callback to determine the connection status.
So I think it would be great to add those to this package.
Please help to review it.