Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the solar system radius calculation #869

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Fix the solar system radius calculation #869

merged 1 commit into from
Jun 4, 2024

Conversation

MegaPiggy
Copy link
Member

Bug fixes

  • Fixed returning to solar system radius not being calculated correctly

needs to divide not multiply
@MegaPiggy
Copy link
Member Author

To explain this. 30000 is the edge, while 24000 is the interloper.
If you did multiplication if your farthest body was at 30000, it would make the edge 24000.
Obviously it should be the opposite and so I changed it to divide.

30000 * (24000 / 30000) => 30000 * 0.8 => 24000
30000 / (24000 / 30000) => 30000 / 0.8 => 37500

@xen-42 xen-42 merged commit 802d6e1 into dev Jun 4, 2024
2 checks passed
@xen-42 xen-42 deleted the radiusCalc branch June 4, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants