Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing RotatedRegion3 issues #1

Closed
Xuleos opened this issue Jun 26, 2020 · 2 comments
Closed

Importing RotatedRegion3 issues #1

Xuleos opened this issue Jun 26, 2020 · 2 comments

Comments

@Xuleos
Copy link
Contributor

Xuleos commented Jun 26, 2020

import { RotatedRegion3 } from "@rbxts/rotatedregion3";
will compile as
local RotatedRegion3 = TS.import(script, TS.getModule(script, "rotatedregion3")).RotatedRegion3
due to the way things are exported in the type definitions

As you can see, this will pretty much guarantee an error in game as RotatedRegion3 is not a member of the RotatedRegion3 class.

@Xuleos
Copy link
Contributor Author

Xuleos commented Jun 26, 2020

#2

@OverHash
Copy link
Owner

Closed via #2

OverHash added a commit that referenced this issue Aug 30, 2024
* fix .AddObject invalid types

* fix invalid return type of .AddObject

* remove typo

* bump version + changelog

* Resolve change #1

Co-authored-by: OverHash <46231745+OverHash@users.noreply.github.com>

* Resolve change #2

Co-authored-by: OverHash <46231745+OverHash@users.noreply.github.com>

* undo wrong type changes

* simplify generics

* update package-lock.json

* simplify .AddObject types even more

* IO -> T

---------

Co-authored-by: OverHash <46231745+OverHash@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants