-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop dependency on deprecated gulp-util
#100
Conversation
Just checking, did you want to include the lock files in the pr? |
@demurgos Thank you for handling this PR! I'll have to look deeper into the lock files to see how I feel about them (though unless it changes anything else drastically, I'm fine with it in principle). I'll most likely accept this PR, but I think I'll have to make this a breaking change release, so it's something I'll want to deal with when I have more time, hopefully over the weekend. |
@stevelacy From a semver point of view, this PR should be a |
@stevelacy @OverZealous |
It's not something I need help with, I just need to make sure I understand the consequences. I haven't had time to look into it yet. I'll try to get to it this week. |
@demurgos Why did you add the package-lock to I was thinking about removing I don't want to simply replace your efforts, so if you could do the following I'll get this merged in an deployed with maybe a minor version bump, since I can't see any major side effects:
Actually, I thought there was more, it's just that 😆. You can include the |
Sure, I'll remove the changes relative to the lock files. I shouldn't have touched them. Even if I personally use lockfiles everywhere, it is not always obvious for libraries (the counter argument is that your CI is no longer tested against the latest version of your dependencies). You may still want to keep the yarn file around, it is used by Travis. |
Yeah, I'm with you (it wasn't me who questioned the lockfile above). I prefer to include lockfiles in my libraries for the reasons you mentioned. If you simply want to include both lockfiles, I'm 100% on board with that, too. :-) And thanks again! |
Okay, I'll push the fix in a few minutes |
Awesome, thanks! I'll get the version bump pushed up and out in a minute. I think you are right that a patch is safe enough for this—I've just had too many things break due to supposedly minor updates in the past, so I'm a bit gun shy on my own libraries. |
Published as v2.2.1. |
Thanks! |
Closes #99