Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: FRU P3 - add swap reminders to Apoc stacks #580

Merged
merged 4 commits into from
Jan 25, 2025

Conversation

wexxlee
Copy link
Collaborator

@wexxlee wexxlee commented Jan 18, 2025

Small tweak to the P3 Apoc stack triggers. If the player takes their first stack on a different side of the boss than they were on when debuffs come out, that swap is detected, and the player will receive a reminder to stay swapped for the second (post-Apoc) and third (post-jump + kb) stacks.

No changes to timing, just outputs. Tested in emulator and in game.

@github-actions github-actions bot added raidboss /ui/raidboss module needs-review Awaiting review labels Jan 18, 2025
Copy link
Collaborator

@valarnin valarnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me in general, but I think there's potential here for the trigger to call out wrong info if e.g. a melee is offset more north/south than east/west for the initial debuff application, but doesn't swap.

It might be better to check directly for east/west by checking just X position?

@github-actions github-actions bot removed the needs-review Awaiting review label Jan 21, 2025
@wexxlee
Copy link
Collaborator Author

wexxlee commented Jan 24, 2025

This worked for me in general, but I think there's potential here for the trigger to call out wrong info if e.g. a melee is offset more north/south than east/west for the initial debuff application, but doesn't swap.

It might be better to check directly for east/west by checking just X position?

Yup, agree that's cleaner.

@github-actions github-actions bot added the needs-review Awaiting review label Jan 24, 2025
@wexxlee wexxlee requested a review from valarnin January 25, 2025 03:17
@valarnin
Copy link
Collaborator

(I'm trying to test this in-game but I'm 0 for 7 on P3 pulls that got to apoc having to flex)

@wexxlee
Copy link
Collaborator Author

wexxlee commented Jan 25, 2025

(I'm trying to test this in-game but I'm 0 for 7 on P3 pulls that got to apoc having to flex)

Well, at least it's not mistakenly telling you to swap. That's a start... 🤣

Copy link
Collaborator

@valarnin valarnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, an entire raid night of never needing to swap/flex later, I give up on being able to test this in-game. Works for all perspectives for every pull across 3 days worth of pulls (~40 pulls checked that had swaps) and they're all correct. I think this is good to merge.

@github-actions github-actions bot removed the needs-review Awaiting review label Jan 25, 2025
@wexxlee wexxlee merged commit e7c70ac into OverlayPlugin:main Jan 25, 2025
10 checks passed
@wexxlee wexxlee deleted the fru-apoc-swaps branch January 25, 2025 09:54
github-actions bot pushed a commit that referenced this pull request Jan 25, 2025
…580)

Small tweak to the P3 Apoc stack triggers. If the player takes their
first stack on a different side of the boss than they were on when
debuffs come out, that swap is detected, and the player will receive a
reminder to stay swapped for the second (post-Apoc) and third (post-jump
+ kb) stacks.

No changes to timing, just outputs.  Tested in emulator and in game. e7c70ac
github-actions bot pushed a commit that referenced this pull request Jan 25, 2025
…580)

Small tweak to the P3 Apoc stack triggers. If the player takes their
first stack on a different side of the boss than they were on when
debuffs come out, that swap is detected, and the player will receive a
reminder to stay swapped for the second (post-Apoc) and third (post-jump
+ kb) stacks.

No changes to timing, just outputs.  Tested in emulator and in game. e7c70ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
raidboss /ui/raidboss module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants