-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raidboss: FRU P3 - add swap reminders to Apoc stacks #580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked for me in general, but I think there's potential here for the trigger to call out wrong info if e.g. a melee is offset more north/south than east/west for the initial debuff application, but doesn't swap.
It might be better to check directly for east/west by checking just X position?
Yup, agree that's cleaner. |
(I'm trying to test this in-game but I'm 0 for 7 on P3 pulls that got to apoc having to flex) |
Well, at least it's not mistakenly telling you to swap. That's a start... 🤣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, an entire raid night of never needing to swap/flex later, I give up on being able to test this in-game. Works for all perspectives for every pull across 3 days worth of pulls (~40 pulls checked that had swaps) and they're all correct. I think this is good to merge.
…580) Small tweak to the P3 Apoc stack triggers. If the player takes their first stack on a different side of the boss than they were on when debuffs come out, that swap is detected, and the player will receive a reminder to stay swapped for the second (post-Apoc) and third (post-jump + kb) stacks. No changes to timing, just outputs. Tested in emulator and in game. e7c70ac
…580) Small tweak to the P3 Apoc stack triggers. If the player takes their first stack on a different side of the boss than they were on when debuffs come out, that swap is detected, and the player will receive a reminder to stay swapped for the second (post-Apoc) and third (post-jump + kb) stacks. No changes to timing, just outputs. Tested in emulator and in game. e7c70ac
Small tweak to the P3 Apoc stack triggers. If the player takes their first stack on a different side of the boss than they were on when debuffs come out, that swap is detected, and the player will receive a reminder to stay swapped for the second (post-Apoc) and third (post-jump + kb) stacks.
No changes to timing, just outputs. Tested in emulator and in game.