Skip to content

Added serialization (ini) of editor settings #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adriengivry merged 1 commit into from
Feb 15, 2025
Merged

Added serialization (ini) of editor settings #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Sources/Overload/OvEditor/include/OvEditor/Settings/EditorSettings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,16 @@ namespace OvEditor::Settings
*/
EditorSettings() = delete;

/**
* Save the settings
*/
static void Save();

/**
* Load the settings
*/
static void Load();

inline static Property<bool> ShowGeometryBounds = { false };
inline static Property<bool> ShowLightBounds = { false };
inline static Property<bool> EditorFrustumGeometryCulling = { true };
Expand Down
3 changes: 3 additions & 0 deletions Sources/Overload/OvEditor/src/OvEditor/Core/Editor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include "OvEditor/Panels/MaterialEditor.h"
#include "OvEditor/Panels/ProjectSettings.h"
#include "OvEditor/Panels/AssetProperties.h"
#include "OvEditor/Settings/EditorSettings.h"

using namespace OvCore::ResourceManagement;
using namespace OvEditor::Panels;
Expand All @@ -34,13 +35,15 @@ OvEditor::Core::Editor::Editor(Context& p_context) :
m_panelsManager(m_canvas),
m_editorActions(m_context, m_panelsManager)
{
Settings::EditorSettings::Load();
SetupUI();

m_context.sceneManager.LoadEmptyLightedScene();
}

OvEditor::Core::Editor::~Editor()
{
Settings::EditorSettings::Save();
m_context.sceneManager.UnloadCurrentScene();
}

Expand Down
43 changes: 42 additions & 1 deletion Sources/Overload/OvEditor/src/OvEditor/Settings/EditorSettings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,45 @@
* @licence: MIT
*/

#include "OvEditor/Settings/EditorSettings.h"
#include "OvEditor/Settings/EditorSettings.h"
#include <OvTools/Filesystem/IniFile.h>

template<class T>
void LoadIniEntry(OvTools::Filesystem::IniFile& iniFile, const std::string& entry, OvEditor::Settings::EditorSettings::Property<T>& out)
{
if (iniFile.IsKeyExisting(entry))
{
out = iniFile.Get<T>(entry);
}
}

void OvEditor::Settings::EditorSettings::Save()
{
std::string editorSettingsPath = std::string(getenv("APPDATA")) + "\\OverloadTech\\OvEditor\\editor.ini";
OvTools::Filesystem::IniFile iniFile(editorSettingsPath);
iniFile.RemoveAll();
iniFile.Add("show_geometry_bounds", ShowGeometryBounds.Get());
iniFile.Add("show_light_bounds", ShowLightBounds.Get());
iniFile.Add("editor_frustum_geometry_culling", EditorFrustumGeometryCulling.Get());
iniFile.Add("editor_frustum_light_culling", EditorFrustumLightCulling.Get());
iniFile.Add("light_billboard_scale", LightBillboardScale.Get());
iniFile.Add("translation_snap_unit", TranslationSnapUnit.Get());
iniFile.Add("rotation_snap_unit", RotationSnapUnit.Get());
iniFile.Add("scaling_snap_unit", ScalingSnapUnit.Get());
iniFile.Rewrite();
}

void OvEditor::Settings::EditorSettings::Load()
{
std::string editorSettingsPath = std::string(getenv("APPDATA")) + "\\OverloadTech\\OvEditor\\editor.ini";
OvTools::Filesystem::IniFile iniFile(editorSettingsPath);

LoadIniEntry<bool>(iniFile, "show_geometry_bounds", ShowGeometryBounds);
LoadIniEntry<bool>(iniFile, "show_light_bounds", ShowLightBounds);
LoadIniEntry<bool>(iniFile, "show_geometry_frustum_culling_in_scene_view", EditorFrustumGeometryCulling);
LoadIniEntry<bool>(iniFile, "show_light_frustum_culling_in_scene_view", EditorFrustumLightCulling);
LoadIniEntry<float>(iniFile, "light_billboard_scale", LightBillboardScale);
LoadIniEntry<float>(iniFile, "translation_snap_unit", TranslationSnapUnit);
LoadIniEntry<float>(iniFile, "rotation_snap_unit", RotationSnapUnit);
LoadIniEntry<float>(iniFile, "scaling_snap_unit", ScalingSnapUnit);
}