Fix OvGame not rendering properly#338
Merged
adriengivry merged 2 commits intodevelopfrom Feb 10, 2025
Merged
Conversation
adriengivry
requested review from
BenjaminViranin,
litelawliet and
maxbrundev
adriengivry
changed the title
adriengivry
force-pushed
the
fix/ovgame_framebuffer
branch
from
918c639 to
d215a76
Compare
adriengivry
changed the title
Member
Author
|
Ready for review! I ended up adding a |
litelawliet
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OvGameisn't properly rendering the game since post-process effects have been added. It seems like drawing directly to the backbuffer isn't supported anymore, as the renderer relies on an output framebuffer.This PR adds a framebuffer to
OvGame, and implements a solution to blit the framebuffer onto the backbuffer.Related Issues
Fixes #337
Fixes #331