Skip to content

Fixed disabled buttons not really disabled #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adriengivry merged 2 commits into from
May 11, 2025
Merged

Fixed disabled buttons not really disabled #506

adriengivry merged 2 commits into from
May 11, 2025

Conversation

@adriengivry
Copy link
Member

@adriengivry adriengivry commented May 11, 2025 •
edited
Loading

Description

  • Fixed disabled buttons still clickable
  • Also removed code that changed the background color of buttons, since the new disabled logic in ImGui also changes the style (no need to manually change the color!)

Related Issue(s)

Fixes #496

Review Guidance

Write here.

Screenshots/GIFs

Write here.

@adriengivry adriengivry self-assigned this May 11, 2025
@adriengivry adriengivry added the Editor Something relative with the editor label May 11, 2025
@adriengivry adriengivry merged commit c63a12d into main May 11, 2025
@adriengivry adriengivry deleted the fix/disabled_button branch May 11, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@adriengivry adriengivry

Labels

Editor Something relative with the editor

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Buttons can still be clicked when they are disabled

2 participants

@adriengivry