Skip to content

Fixed asset rename bug #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adriengivry merged 1 commit into from
May 21, 2025
Merged

Fixed asset rename bug #549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions Sources/Overload/OvEditor/src/OvEditor/Panels/AssetBrowser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,7 @@ void OvEditor::Panels::AssetBrowser::ConsiderItem(OvUI::Widgets::Layout::TreeNod
return;
}

std::string path = p_entry.path().string();
const std::string path = p_entry.path().string();

const std::string resourceFormatPath = EDITOR_EXEC(GetResourcePath(path, p_isEngineItem));
const bool protectedItem = !p_root || p_isEngineItem;
Expand Down Expand Up @@ -1221,23 +1221,23 @@ void OvEditor::Panels::AssetBrowser::ConsiderItem(OvUI::Widgets::Layout::TreeNod
fileType == OvTools::Utils::PathParser::EFileType::SHADER ||
fileType == OvTools::Utils::PathParser::EFileType::SHADER_PART)
{
clickableText.DoubleClickedEvent += [path] {
OvTools::Utils::SystemCalls::OpenFile(path);
clickableText.DoubleClickedEvent += [&contextMenu] {
OvTools::Utils::SystemCalls::OpenFile(contextMenu.filePath.string());
};
}

if (fileType == OvTools::Utils::PathParser::EFileType::MODEL)
{
clickableText.DoubleClickedEvent += [path, p_isEngineItem] {
auto& res = GetResource<OvCore::ResourceManagement::ModelManager>(path, p_isEngineItem);
clickableText.DoubleClickedEvent += [&contextMenu, p_isEngineItem] {
auto& res = GetResource<OvCore::ResourceManagement::ModelManager>(contextMenu.filePath.string(), p_isEngineItem);
OpenInAssetView(res);
};
}

if (fileType == OvTools::Utils::PathParser::EFileType::MATERIAL)
{
clickableText.DoubleClickedEvent += [path, p_isEngineItem] {
auto& res = GetResource<OvCore::ResourceManagement::MaterialManager>(path, p_isEngineItem);
clickableText.DoubleClickedEvent += [&contextMenu, p_isEngineItem] {
auto& res = GetResource<OvCore::ResourceManagement::MaterialManager>(contextMenu.filePath.string(), p_isEngineItem);
OpenInAssetView(res);
EDITOR_EXEC(DelayAction([&res]() { OpenInMaterialEditor(res); }));
};
Expand All @@ -1248,16 +1248,16 @@ void OvEditor::Panels::AssetBrowser::ConsiderItem(OvUI::Widgets::Layout::TreeNod
auto& texturePreview = clickableText.AddPlugin<TexturePreview>();
texturePreview.SetPath(resourceFormatPath);

clickableText.DoubleClickedEvent += [path, p_isEngineItem] {
auto& res = GetResource<OvCore::ResourceManagement::TextureManager>(path, p_isEngineItem);
clickableText.DoubleClickedEvent += [&contextMenu, p_isEngineItem] {
auto& res = GetResource<OvCore::ResourceManagement::TextureManager>(contextMenu.filePath.string(), p_isEngineItem);
OpenInAssetView(res);
};
}

if (fileType == OvTools::Utils::PathParser::EFileType::SCENE)
{
clickableText.DoubleClickedEvent += [path] {
EDITOR_EXEC(LoadSceneFromDisk(EDITOR_EXEC(GetResourcePath(path))));
clickableText.DoubleClickedEvent += [&contextMenu] {
EDITOR_EXEC(LoadSceneFromDisk(EDITOR_EXEC(GetResourcePath(contextMenu.filePath.string()))));
};
}
}
Expand Down