-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema: Remove mixed types: road.flags (Parquet compatibility) #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheRBajaj need to fix counterexamples.
- There are many existing
counterexamples
that have the old-style flags, but where the intention of those counterexamples isn't to find an error in theroad.flags
property. Can you please find and fix them all to use new-style flags? - Please get in the habit of looking for counterexamples to fix when doing schema changes!
- Could you also add one counterexample that explicitly tests for invalid old-style flags?
@TheRBajaj are you using the pull request template? Looking at this PR's description, it looks like the template was deleted or trimmed-down. If you're doing that, it's preferable not to. These are the benefits of the PR template:
|
2233e6d
20b6295
to
2233e6d
Compare
counterexamples/transportation/segment/road/bad-road-flags-invalid-string-value.json
Outdated
Show resolved
Hide resolved
2233e6d
to
c6ebccd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__
/ \--..____
\ \ \-----,,,..
\ \ \ \--,,..
\ \ \ \ ,'
\ \ \ \ ``..
\ \ \ \-''
\ \ \__,,--'''
\ \ \.
\ \ ,/
\ \__..-
\ \
\ \
\ \ :F_P:
\ \
\ \
\ \
\ \
\ \
\ \
counterexamples/transportation/segment/road/restrictions/turns/bad-turns-reason.yaml
Outdated
Show resolved
Hide resolved
c6ebccd
to
eb1d6ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you have some conflicts to resolve first but LGTM!
I see it also. @TheRBajaj could you resolve the conflict to make this PR mergable? |
37da66c
Merging this despite the fact that validation is currently broken. Some cross-PR conflicts caused merging several previous PRs that by themselves were fine to break validation. It will be easier to merge this first, then fix after. |
Co-authored-by: Rahul Bajaj <rbajajj@amazon.com> Co-authored-by: Victor Schappert <schapper@amazon.com>
Co-authored-by: Rahul Bajaj <rbajajj@amazon.com> Co-authored-by: Victor Schappert <schapper@amazon.com>
Co-authored-by: Rahul Bajaj <rbajajj@amazon.com> Co-authored-by: Victor Schappert <schapper@amazon.com>
Co-authored-by: Rahul Bajaj <rbajajj@amazon.com> Co-authored-by: Victor Schappert <schapper@amazon.com>
Co-authored-by: Rahul Bajaj <rbajajj@amazon.com> Co-authored-by: Victor Schappert <schapper@amazon.com>
Description
This PR removes the mixed schema types for
road.flags
propertyBefore
road.flags
could accept multiple types of values that could be put into the same property like array and string values.After
roads.flags
only accepts array property instead of array and stringReference
https://github.com/OvertureMaps/tf-transportation/issues/57
Testing
Tested using test script
Checklist