-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "value" as required element of address_level #283
Conversation
Note to myself: We had meant to allow |
b2557a2
Reason for Agreed 2024-10-02 Schema TF meeting: We'll follow this approach and try to avoid explicit There's an open point about whether |
Category
What kind of change is this?
Please select one of the following four options.
Consult Pull request merging criteria for a description of each category.
Description
This fixes a bug in the schema where unknown address_levels were disallowed. Allow them by still requiring the
addressLevelContainer struct, but make the "value" field optional.
Reference
List of relevant links to GitHub issues, PRs, and other documentation.
Testing
jv
Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
A
but is not intended to test propertyA
's validity, and you made a schema change that invalidates propertyA
in that counterexample, fix the counterexample to align it with your schema change.Documentation Website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.