Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference to new divisions macrohood subtype #290

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

stepps00
Copy link
Contributor

@stepps00 stepps00 commented Oct 17, 2024

Category

What kind of change is this?
Please select one of the following four options.
Consult Pull request merging criteria for a description of each category.

  1. Cosmetic change.
  2. Documentation change by member.
  3. Documentation change by Overture tech writer.
  4. Material change.

Description

In October, the Divisions theme will see features at a new macrohood subtype. This pull request adds references and definitions for the new subtype to the division.mdx and division_area.mdx files.

TODO.

Reference

https://github.com/OvertureMaps/tf-admin/issues/132

  1. TODO.

Testing

Brief description of the testing done for this change showing why you are confident it works as expected and does not introduce regressions. Provide sample output data where appropriate.

TODO.

Checklist

Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.

  1. Add relevant examples.
  2. Add relevant counterexamples.
  3. Update any counterexamples that became obsolete. For example, if a counterexample uses property A but is not intended to test property A's validity, and you made a schema change that invalidates property A in that counterexample, fix the counterexample to align it with your schema change.
  4. Update in-schema documentation using plain English written in complete sentences, if an update is required.
  5. Update Docusaurus documentation, if an update is required.
  6. Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation Website

Update the hyperlink below to put the pull request number in.

Docs preview for this PR.

@stepps00 stepps00 self-assigned this Oct 17, 2024
@stepps00 stepps00 requested a review from danabauer October 17, 2024 21:44
Copy link
Contributor

@danabauer danabauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating this

@vcschapp vcschapp self-requested a review October 23, 2024 14:55
@vcschapp
Copy link
Collaborator

vcschapp commented Oct 23, 2024

@stepps00 is this still work in progress? (Has [WIP] in the title.)

Also, was there a schema change to go along with this docs change?

@stepps00 stepps00 changed the title [WIP] Add reference to new divisions macrohood subtype Add reference to new divisions macrohood subtype Oct 23, 2024
@stepps00
Copy link
Contributor Author

Thanks, I just removed [WIP] from the title.

I don't think a schema change is required here since we're only adding a new value to an existing field (subtype).

@stepps00
Copy link
Contributor Author

@vcschapp commits updated, this should be ready to merge.

@vcschapp vcschapp merged commit f351955 into dev Oct 23, 2024
2 checks passed
@vcschapp vcschapp deleted the stepps00/macrohood branch October 23, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants