Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Add is_land and is_territorial to divisions #303

Merged
merged 5 commits into from
Jan 15, 2025
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions counterexamples/divisions/division_area/bad-is-land.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
id: counterexample:division_area:bad-is-land
type: Feature
geometry:
type: LineString
coordinates: [[0, 1], [1, 2]]
properties:
theme: divisions
type: division_area
version: 0
subtype: country
division_id: counterexample:division_boundary:some-division
is_land: yes
country: ZZ
ext_expected_errors:
- "is_land/type]: got string, want boolean"
16 changes: 16 additions & 0 deletions counterexamples/divisions/division_area/bad-is-territorial.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
id: counterexample:division_area:bad-is-territorial
type: Feature
geometry:
type: LineString
coordinates: [[0, 1], [1, 2]]
properties:
theme: divisions
type: division_area
version: 0
subtype: country
division_id: counterexample:division_boundary:some-division
is_territorial: no
country: ZZ
ext_expected_errors:
- "is_territorial/const]: value must be true"
17 changes: 17 additions & 0 deletions counterexamples/divisions/division_boundary/bad-is-land.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
id: counterexample:division_boundary:bad-is-land
type: Feature
geometry:
type: LineString
coordinates: [[0, 1], [1, 2]]
properties:
theme: divisions
type: division_boundary
version: 0
subtype: country
division_ids: ["example:division:country:left", "example:division:country:right"]
is_land: yes
class: land
country: ZZ
ext_expected_errors:
- "is_land/const]: value must be true"
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
id: counterexample:division_boundary:bad-is-territorial
type: Feature
geometry:
type: LineString
coordinates: [[0, 1], [1, 2]]
properties:
theme: divisions
type: division_boundary
version: 0
subtype: country
division_ids: ["example:division:country:left", "example:division:country:right"]
class: land
is_territorial: no
country: ZZ
ext_expected_errors:
- "is_territorial/const]: value must be true"
17 changes: 17 additions & 0 deletions counterexamples/divisions/division_boundary/bad-not-both.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
id: example:division_boundary:is_land:country:us
type: Feature
geometry:
type: LineString
coordinates: [[0, 1], [1, 2]]
properties:
theme: divisions
type: division_boundary
version: 1
subtype: country
is_land: true
is_territorial: true
class: land
division_ids: ["example:division:country:left", "example:division:country:right"]
ext_expected_errors:
- "division_boundary.yaml#/properties/properties/oneOf]: oneOf failed, subschemas 0, 1 matched"
1 change: 1 addition & 0 deletions examples/divisions/division_area/country_land.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ properties:
version: 0
subtype: country
class: land
sasastanojkov marked this conversation as resolved.
Show resolved Hide resolved
is_land: true
division_id: example:division:country:us
names:
primary: United States
Expand Down
1 change: 1 addition & 0 deletions examples/divisions/division_area/country_maritime.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ properties:
version: 0
subtype: country
class: maritime
is_territorial: true
division_id: example:division:country:fi
names:
primary: Suomi
Expand Down
Loading
Loading