Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add entityId optional property #47

Merged
merged 1 commit into from
Sep 7, 2023
Merged

add entityId optional property #47

merged 1 commit into from
Sep 7, 2023

Conversation

ibnt1
Copy link
Contributor

@ibnt1 ibnt1 commented Aug 29, 2023

add entityId optional property to all overture features as 32 hex characters string.

@ibnt1 ibnt1 requested a review from vcschapp August 30, 2023 00:10
Copy link
Collaborator

@vcschapp vcschapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--    .-""-.
   ) (     )
  (   )   (
     /     )
    (_    _)                     0_,-.__
      (_  )_                     |_.-._/
       (    )                    |_--..\
        (__)                     |__--_/
     |''   ``\                   |
     |        \                  |      /b.
     |         \  ,,,---===?A`\  |  ,==y'
   ___,,,,,---==""\        |M] \ | ;|\ |>
           _   _   \   ___,|H,,---==""""bno,
    o  O  (_) (_)   \ /          _     AWAW/
                     /         _(+)_  dMM/
      \@_,,,,,,---=="   \      \\|//  MW/
--''''"                         ===  d/
                                    //
                                    ,'__________________________
   \    \    \     \               ,/~~~~~~~~~~~~~~~~~~~~~~~~~~~
                         _____    ,'  ~~~   .-""-.~~~~~~  .-""-.
      .-""-.           ///==---   /`-._ ..-'      -.__..-'
            `-.__..-' =====\\\\\\ V/  .---\.
 PGMG                 ~~~~~~~~~~~~, _',--/_.\  .-""-.
                            .-""-.___` --  \|         -.__..-

Comment on lines +10 to +11
type: string
pattern: ^[0-9a-f]{32}$
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advanced validation thought: we could probably figure out a way to assert in validation that id != entityId.

For later.

@ibnt1 ibnt1 marked this pull request as ready for review August 30, 2023 16:29
@aluwihar aluwihar merged commit 90020fd into dev Sep 7, 2023
@jenningsanderson jenningsanderson deleted the users/ibnt1/entityid branch November 16, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants