Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small issues in transportation docs #48

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Fix small issues in transportation docs #48

merged 2 commits into from
Sep 7, 2023

Conversation

vcschapp
Copy link
Collaborator

@vcschapp vcschapp commented Sep 1, 2023 •
edited
Loading

Description

  • Delete some TODO items in an example that are bleeding into the official docusaurus website.
  • Fix a few small typos.
  • Add a hidden TODO to provide an example about rule-based properties to help readers concretize the fairly abstract wording.

Thanks!

Thanks to Karen for pointing these out.

Testing

See staging docs version of changes here: https://dfhx9f55j8eg5.cloudfront.net/pr/48/themes/transportation/

@vcschapp
Drop TODO comments that are bleeding into the official docs website
7e1515a 
Thanks to Karen.Calus@tomtom.com for bringing this to my attention...
@vcschapp
Fix typos in transportation docusaurus website
93756fe 
Again thanks to Karen.Calus@tomtom.com for finding these...
@karencalus-tomtom karencalus-tomtom deleted the transportation_better_docs branch September 7, 2023 06:55
@karencalus-tomtom karencalus-tomtom restored the transportation_better_docs branch September 7, 2023 07:12
karencalus-tomtom
karencalus-tomtom approved these changes Sep 7, 2023
View reviewed changes
Copy link

@karencalus-tomtom karencalus-tomtom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good

@aluwihar aluwihar merged commit 3a5e5b6 into main Sep 7, 2023
4 checks passed
@jenningsanderson jenningsanderson deleted the transportation_better_docs branch November 16, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjibdutta1 sanjibdutta1 sanjibdutta1 approved these changes

@karencalus-tomtom karencalus-tomtom karencalus-tomtom approved these changes

@AleksandraDebicka-TomTom AleksandraDebicka-TomTom AleksandraDebicka-TomTom approved these changes

@larryfreil larryfreil larryfreil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vcschapp @larryfreil @AleksandraDebicka-TomTom @karencalus-tomtom @sanjibdutta1 @aluwihar