-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce building parts #51
Conversation
03df0f9
to
cbdc2bc
Compare
Still todo:
|
View the change in the documentation: https://dfhx9f55j8eg5.cloudfront.net/pr/51/reference/buildings/building |
@jwass Looking at the PR, I can't quite tell where the building ID that the part belongs to should go. Is it just an attribute underneath "properties" like this?
|
@jwass Is the PR updated to show where the building ID value should go? Not sure if I missed it somewhere. |
@jwass How should I submit the sample data I put together? |
@jwass Should I make a new PR or add to this one? |
Add the notion of a building part. Both building footprints and building parts share in some shape definitions. These are pulled out in a common defs.yaml file which are shared by buildings (footprints) and parts. Validated/tested with the test.sh script
Was missing the building id in the part example
051d72f
to
6bcdc41
Compare
examples/buildings/osm/outline.json
Outdated
"sources": [{ | ||
"property": "", | ||
"dataset": "OpenStreetMap" | ||
}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add hasParts set to True
Outstanding issue: https://github.com/OvertureMaps/tf-buildings/issues/24 before merging |
Should we include |
@LukaszMichalski-TomTom I think we agreed at the meeting this is a good idea. Want to take a stab at adding it here? |
@jwass I don't have permission to commit to this repo. I prepared the change, but I cannot push it. |
Can you make a pull request to this branch? Or can't even do that? |
Can you try again? You should have permissions now |
facadeMaterial, roofMaterial and facadeColor properties
Introduce the building part schema. Parts and main footprints share shape information.