Skip to content

Typo in Index buffer Section #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zixin96 opened this issue May 11, 2022 · 1 comment
Closed

Typo in Index buffer Section #288

zixin96 opened this issue May 11, 2022 · 1 comment

Comments

@zixin96
Copy link

zixin96 commented May 11, 2022

Hello, I've found some inconsistencies between the text and the source code in the index buffer section.
1.

Using an index buffer for drawing involves two changes to createCommandBuffers. 

In the source code, we made changes to recordCommandBuffer instead of createCommandBuffers.

The text shows

vkCmdBindVertexBuffers(commandBuffers[i], 0, 1, vertexBuffers, offsets);
vkCmdBindIndexBuffer(commandBuffers[i], indexBuffer, 0, VK_INDEX_TYPE_UINT16);
vkCmdDrawIndexed(commandBuffers[i], static_cast<uint32_t>(indices.size()), 1, 0, 0, 0);

, but the source code shows:

vkCmdBindVertexBuffers(commandBuffer, 0, 1, vertexBuffers, offsets);
vkCmdBindIndexBuffer(commandBuffer, indexBuffer, 0, VK_INDEX_TYPE_UINT16);
vkCmdDrawIndexed(commandBuffer, static_cast<uint32_t>(indices.size()), 1, 0, 0, 0);

Thanks,
Zixin

@Overv Overv closed this as completed in 29ab167 May 16, 2022
@Overv
Copy link
Owner

Overv commented May 16, 2022

Thanks for reporting. I've fixed this and a bunch of other inconsistencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants