Skip to content

vkDestroyDescriptorPool added to Descriptor pool and sets #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2022
Merged

vkDestroyDescriptorPool added to Descriptor pool and sets #273

merged 3 commits into from
Mar 1, 2022

Conversation

Onyrew
Copy link
Contributor

@Onyrew Onyrew commented Feb 28, 2022

The vkDestroyDescriptorPool is missing from the tutorial and vulkan gives a warning for it.
However it is present in the code examples in the github repo: 23_descriptor_sets.cpp

@Overv
Copy link
Owner

Overv commented Mar 1, 2022

Excellent, could you add it to the French version of the chapter as well?

@Onyrew
Copy link
Contributor Author

Onyrew commented Mar 1, 2022

I added it, I think it should be in the right place.

@Overv Overv merged commit 608b986 into Overv:master Mar 1, 2022
@Overv
Copy link
Owner

Overv commented Mar 1, 2022

Thanks for fixing this :)

Overv pushed a commit that referenced this pull request Mar 8, 2023
* vkDestroyDescriptorPool  added

* dots

* vkDestroyDescriptorPool added for French chapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants