Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hello, I made a sight.js to hide the cursor, to make it more looks like miecraft #36

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Jim-JZ-Chen
Copy link

hello, I made a sight.js to hide the cursor, to make it more looks like miecraft

@Overv
Copy link
Owner

Overv commented Jul 7, 2018

Could you elaborate on your pull request? That's a lot of code changes to just hide the cursor.

@warengonzaga
Copy link

@dfjhde please add comments on your code... it is hard to know if it is required to change or not.

@Jim-JZ-Chen
Copy link
Author

@warengonzaga i just added more comments on my code, please tell me specifically if you have problem on my code, thank you!

@warengonzaga
Copy link

@Jim-JZ-Chen okay got it... will review it...

@warengonzaga
Copy link

@Jim-JZ-Chen there is an issue when moving the mouse in smaller screen... the most are not able to move when it is on a small screen. Please fix it... I don't understand if the full screen is necessary.

@SmilerRyan
Copy link

The script works good, however I cannot seem to select different blocks while using this.
I think you should add a way to toggle it with a key, or disable looking while a key is being held.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants