Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract first and last timestamp from input csv data #41

Closed
wants to merge 1 commit into from

Conversation

LauraBrocks
Copy link

Addressing bug found in #40

start_time = pd.to_datetime(info['StartTime'])
end_time = pd.to_datetime(info['EndTime'])
start_time = pd.to_datetime(data['time'].iloc[0])
end_time = pd.to_datetime(data['time'].iloc[-1])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This always overwrites the start and end time, even for the axivity device. Perhaps this should only be done for csv files.

Copy link
Member

@angerhang angerhang Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR still active?

Also, to avoid using magic numbers, we can name 0, and -1 as start_time_idx or end_time_idx.

@LauraBrocks
Copy link
Author

LauraBrocks commented Oct 25, 2023 via email

@angerhang
Copy link
Member

Closing this PR as the code is better factored in #51

@angerhang angerhang closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants