Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port embedding #30

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Port embedding #30

merged 6 commits into from
Nov 25, 2024

Conversation

mihaeladuta
Copy link
Contributor

No description provided.

@mihaeladuta mihaeladuta requested a review from abhidg November 22, 2024 15:43
@mihaeladuta
Copy link
Contributor Author

@abhidg Please review the commit 8bd5812 that aims to avoid the use of a global.

abhidg
abhidg approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@abhidg abhidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mihaeladuta mihaeladuta merged commit c283f4e into main Nov 25, 2024
4 checks passed
@mihaeladuta mihaeladuta deleted the port_embedding branch November 25, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhidg abhidg abhidg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihaeladuta @abhidg