Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update Docker dev environment #289

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

eatyourgreens
Copy link
Contributor

  • add some more local code directories to the docker dev build.
  • update the docs.

- add some more local code directories to the docker dev build.
- update the docs.
Comment on lines 31 to 36
- ./.material:/app/.material
- ./config:/app/config
- ./components:/app/components
- ./pages:/app/pages
- ./public:/app/public
- ./styles:/app/styles
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've got all the places that you might want to make changes while working on the app, but I could be wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few more (lib, scripts, config, docs, ...). Perhaps you could map the entire root dir to /app/?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about directories like docs, because they aren't used by the running Next.js app.

It might be worth adding a docs service to the compose file, though, so you could see the Next.js app on one port, and the docs site on another.

I'm also wondering whether to add a CLI shell so that people can run yarn scripts inside a container. At the moment, you can't easily run the tests in Docker.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried running the tests in a container, and they failed with missing dependency errors. That's a problem for another day.

docker compose -f docker-compose.dev.yml run --rm gutenberg yarn e2e

Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib would be an important directory to include

Comment on lines 31 to 36
- ./.material:/app/.material
- ./config:/app/config
- ./components:/app/components
- ./pages:/app/pages
- ./public:/app/public
- ./styles:/app/styles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few more (lib, scripts, config, docs, ...). Perhaps you could map the entire root dir to /app/?

- ./pages:/app/pages
- ./public:/app/public
- ./styles:/app/styles
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts folder too.

You also need files from the base directory, the next.config, the cypress.config and possibly the cypress.d?, tsconfig, tailwind config, the .env and .local.env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants