Initial work on header for code blocks #40
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| headerColor = 'bg-red-300 dark:bg-red-700' | ||
| } | ||
|
|
||
| const copyToClipboardButton = ( |
There was a problem hiding this comment.
its generally good to refactor these things into their own react component, e.g. Button. We are actually already using a component library called https://www.flowbite-react.com/, which provides such a button, but I wrote this function before I started using it.
| </CopyToClipboard> | ||
| ) | ||
|
|
||
| const headerBox = ( |
There was a problem hiding this comment.
again this could be a separate HeaderBox component. Note that I realise I've been a bit lazy and not done this in many places :) so I'm not saying do this now, just that in the future we should build up a library of components we us across the site, so the styling is consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready yet.