Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy Repo #206

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Lazy Repo #206

merged 6 commits into from
Aug 17, 2023

Conversation

Oxid15
Copy link
Owner

@Oxid15 Oxid15 commented Aug 17, 2023

This makes ModelRepo lazy in relation to the line creation - now it only stores names and line params passed in the constructor and creates only on __getitem__
The exception is the add_line method which records the arguments, creates and returns the line immediately

The motivation to this change was to unify collections - ModelLine always was lazy, so it is the Workspace.

@Oxid15 Oxid15 self-assigned this Aug 17, 2023
@Oxid15 Oxid15 merged commit aa57e28 into 0.13.0 Aug 17, 2023
@Oxid15 Oxid15 deleted the lazy_repo branch August 17, 2023 20:39
@Oxid15 Oxid15 mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant