Feat/asidbar Sidbar Component style #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pointer 컴포넌트의 좌표 버그가 발견되었습니다. ㅠ 수정중입니다 |
CSKIM999
approved these changes
Mar 11, 2024
| @@ -11,7 +11,7 @@ function getAbsolutePath(value: string): any { | |||
| } | |||
| const config: StorybookConfig = { | |||
| stories: ["../src/**/*.mdx", "../src/**/*.stories.@(js|jsx|mjs|ts|tsx)"], | |||
| staticDirs: ["../public"], | |||
| staticDirs: ["../src/assets"], | |||
There was a problem hiding this comment.
이 부분은 public 에서 가져 올 staticAssets 경로를 설정해야하니 public이 맞지 않나요?
There was a problem hiding this comment.
저도 해당 부분 public이라고 생각이 드는데, 다음과 같이 바꾼 이유가 있나요?
There was a problem hiding this comment.
저희가 public 폴더가 없어서 에러가 발생하는 군요..
There was a problem hiding this comment.
오잉 근데 제가 이상한지는 모르겠는데 없기는 합니다
There was a problem hiding this comment.
#12 (comment)
음 제 경우에는 public경로가 없어서 에러가 발생합니다
src/components/Sidebar/Sidebar.tsx
Outdated
Comment on lines
12
to
13
| const height = groups.length * 80 + 80; | ||
| const pointerY = selectedIdx * 64 + 24 - 4; |
There was a problem hiding this comment.
이 부분의 매직넘버들은 해당 파일의 상단에 상수로 빼서 작성해주시면 더 좋을 것 같습니다. 어떤 숫자들인지 저는 잘 모르겠네요.
There was a problem hiding this comment.
넵 그렇게 수정해보도록 하겠습니다 👍
yeongjunekoh
approved these changes
Mar 11, 2024
| import { MouseEventHandler } from "react"; | ||
| import { motion } from "framer-motion"; | ||
| import clsx from "clsx"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 분류
작업 상세 내용
1. sidebar의 스타일 및 애니메이션을 추가했습니다.
어떤 그룹을 선택했는지 알기 쉽도록 Pointer컴포넌트를 추가하였으며, 선택한 그룹으로 이동하도록 구현하였습니다.
2. framer-motion 패키지를 추가하였습니다.
애니메이션을 구현하기 위헤 framer-motion패키지를 추가하였으며, Pointer컴포넌트 및 Group컴포넌트에서 사용하였습니다.