Feat/firebase authentication #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinivin153
approved these changes
Mar 4, 2024
firebase/firebasedb.ts
Outdated
Comment on lines
4
to
12
| const firebaseConfig = { | ||
| apiKey: process.env.NEXT_PUBLIC_FIREBASE_API_KEY, | ||
| authDomain: process.env.NEXT_PUBLIC_FIREBASE_AUTH_DOMAIN, | ||
| projectId: process.env.NEXT_PUBLIC_FIREBASE_PROJECT_ID, | ||
| storageBucket: process.env.NEXT_PUBLIC_FIREBASE_STORAGE_BUCKET, | ||
| messagingSenderId: process.env.NEXT_PUBLIC_FIREBASE_MESSAGING_SENDER_ID, | ||
| appId: process.env.NEXT_PUBLIC_FIREBASE_APP_ID, | ||
| measurementId: process.env.NEXT_PUBLIC_FIREBASE_MEASUREMENT_ID, | ||
| }; |
There was a problem hiding this comment.
찬섭님이 작성한 src/constants/firebase.ts 이용해도 좋을 것 같습니다!
There was a problem hiding this comment.
동의합니다! 동일한 폴더/파일에 객체로 관리되면 더욱 좋을 것같아요
There was a problem hiding this comment.
찬섭님께서 작성해주신 동일 파일로 수정완료하였습니다 ✅
yeongjunekoh
requested changes
Mar 4, 2024
There was a problem hiding this comment.
전반적으로 작업하신 사항들 모두 확인하였습니다!
카카오와 소셜 로그인 연동 부분은 아직 안되어있는 것으로 확인했습니다:D
요것은 폴더 구조와 관련된 것인데, component안에 LoginForm과 같은 폴더를 만든 뒤에 세부 사항에서 index.tsx처럼 관리하는 것이 어떨지요?
components
| - LoginForm
| | - index.tsx
| | - index.module.css
| - SignupForm
| | - index.tsx
| | - index.module.css
해당 부분은 저희 모두 공통적으로 맞춰야 하는 부분이기에 논의에 한 번 올리도록하겠습니다!
+) PR도 문서화를 신경쓰면 어떨까라는 생각입니다!
+) 해당 CSS 모듈에서 tailwind 프레임워크를 사용하게 css 변경 요청드립니다!
firebase/firebasedb.ts
Outdated
Comment on lines
4
to
12
| const firebaseConfig = { | ||
| apiKey: process.env.NEXT_PUBLIC_FIREBASE_API_KEY, | ||
| authDomain: process.env.NEXT_PUBLIC_FIREBASE_AUTH_DOMAIN, | ||
| projectId: process.env.NEXT_PUBLIC_FIREBASE_PROJECT_ID, | ||
| storageBucket: process.env.NEXT_PUBLIC_FIREBASE_STORAGE_BUCKET, | ||
| messagingSenderId: process.env.NEXT_PUBLIC_FIREBASE_MESSAGING_SENDER_ID, | ||
| appId: process.env.NEXT_PUBLIC_FIREBASE_APP_ID, | ||
| measurementId: process.env.NEXT_PUBLIC_FIREBASE_MEASUREMENT_ID, | ||
| }; |
There was a problem hiding this comment.
동의합니다! 동일한 폴더/파일에 객체로 관리되면 더욱 좋을 것같아요
Code Review 꼼꼼히 해주심에 감사드립니다 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.