Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove exclude-empty option #213

Draft
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

P403n1x87
Copy link
Owner

The option has been broken for the past few releases and it didn't seem to cause major issues. So we make the assumption that this option is not used frequently and therefore we make the decision to drop it.

Requirements for Adding, Changing, Fixing or Removing a Feature

Fill out the template below. Any pull request that does not include enough
information to be reviewed in a timely manner may be closed at the maintainers'
discretion.

Description of the Change

Alternate Designs

Regressions

Verification Process

@P403n1x87 P403n1x87 modified the milestones: Austin 3, Austin 3.7 Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.97%. Comparing base (5303860) to head (b2dd9c8).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #213      +/-   ##
==========================================
+ Coverage   68.79%   68.97%   +0.17%     
==========================================
  Files          27       27              
  Lines        2519     2514       -5     
  Branches      774      773       -1     
==========================================
+ Hits         1733     1734       +1     
+ Misses        457      446      -11     
- Partials      329      334       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 29, 2024

Austin Benchmarks

Running Austin benchmarks with Python 3.10.13

Benchmark Summary

Comparison of dev against 3.6.0.

The following scenarios show a statistically significant difference in performance between the two versions.

Sample Rate Saturation Error Rate Sampling Speed
Wall time [sampling interval: 1] 🟡 🟢 🟡 🟡
CPU time [sampling interval: 1] 🟡 🟡 🔴 🟡
CPU time [sampling interval: 1000] 🔴 🟡 🟡 🟡
RSA keygen [sampling interval: 1000] 🟡 🟡 🟡 🔴
Full metrics [sampling interval: 1] 🟡 🟡 🔴 🟡
Full metrics [sampling interval: 10] 🟢 🟡 🟡 🟢

Benchmark Results

Wall time [sampling interval: 1]

Wall time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 197000 ± 7000 0.99996 ± 2e-05 3e-06 ± 3e-06 7.5 ± 0.7
dev 199000 ± 3000 0.9999 ± 6e-05 3e-06 ± 3e-06 7.6 ± 0.5
Wall time [sampling interval: 10]

Wall time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 62000 ± 7000 0.36 ± 0.04 8e-06 ± 8e-06 9.5 ± 0.5
dev 66000 ± 9000 0.37 ± 0.05 1e-05 ± 1e-05 9.4 ± 0.5
Wall time [sampling interval: 100]

Wall time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 12400 ± 200 0.0004 ± 0.0001 0 ± 0 9.2 ± 0.8
dev 12300 ± 200 0.0005 ± 0.0002 0.0 ± 2e-05 9.0 ± 0.7
Wall time [sampling interval: 1000]

Wall time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 1860 ± 20 0 ± 0 0 ± 0 11 ± 1
dev 1850 ± 30 0 ± 0 0.0 ± 0.0001 11 ± 1
CPU time [sampling interval: 1]

CPU time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 60000 ± 3000 1 ± 0 8e-06 ± 9e-06 13.1 ± 0.6
dev 61000 ± 2000 1 ± 0 2.1e-05 ± 7e-06 12.8 ± 0.6
CPU time [sampling interval: 10]

CPU time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 58000 ± 3000 0.63 ± 0.05 1e-05 ± 1e-05 13.3 ± 0.5
dev 57000 ± 2000 0.64 ± 0.07 2e-05 ± 2e-05 13.2 ± 0.4
CPU time [sampling interval: 100]

CPU time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 6360 ± 30 0.0008 ± 0.0003 2e-05 ± 6e-05 16 ± 1
dev 6363 ± 8 0.0008 ± 0.0001 5e-05 ± 5e-05 17 ± 1
CPU time [sampling interval: 1000]

CPU time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 947.9 ± 1.0 0 ± 0 0 ± 0 19 ± 2
dev 946.2 ± 0.9 0 ± 0 0.0003 ± 0.0006 21 ± 1
RSA keygen [sampling interval: 1]

RSA keygen [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 61000 ± 4000 1 ± 0 0.0001 ± 7e-05 16.0 ± 0.9
dev 63000 ± 5000 1 ± 0 0.0002 ± 0.0002 15.1 ± 1.0
RSA keygen [sampling interval: 10]

RSA keygen [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 61000 ± 4000 0.995 ± 0.005 0.0001 ± 0.0001 15.5 ± 1.0
dev 62000 ± 3000 0.995 ± 0.003 0.0002 ± 0.0002 15.5 ± 0.8
RSA keygen [sampling interval: 100]

RSA keygen [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 6340 ± 30 0.001 ± 0.001 0.0004 ± 0.0003 19 ± 3
dev 6340 ± 30 0.002 ± 0.004 0.0006 ± 0.0006 22 ± 4
RSA keygen [sampling interval: 1000]

RSA keygen [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 945.2 ± 0.8 0 ± 0 0.0003 ± 0.0006 19 ± 2
dev 945 ± 1 0 ± 0 0.001 ± 0.002 24 ± 5
Full metrics [sampling interval: 1]

Full metrics [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 75000 ± 2000 1 ± 0 7e-06 ± 6e-06 19.9 ± 0.7
dev 76000 ± 2000 1 ± 0 1.6e-05 ± 7e-06 19.4 ± 0.5
Full metrics [sampling interval: 10]

Full metrics [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 75000 ± 1000 0.88 ± 0.03 1.4e-05 ± 9e-06 19.9 ± 0.7
dev 77000 ± 1000 0.87 ± 0.02 1.8e-05 ± 9e-06 19.1 ± 0.3
Full metrics [sampling interval: 100]

Full metrics [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 12300 ± 200 0.0013 ± 0.0005 3e-05 ± 4e-05 24 ± 1
dev 12400 ± 200 0.0013 ± 0.0003 2e-05 ± 3e-05 24.3 ± 0.8
Full metrics [sampling interval: 1000]

Full metrics [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 1870 ± 20 0 ± 0 0 ± 0 29 ± 1
dev 1860 ± 20 0 ± 0 0.0001 ± 0.0002 29 ± 2
Multiprocess wall time [sampling interval: 1]

Multiprocess wall time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 6800 ± 700 1 ± 0 7e-05 ± 3e-05 130 ± 10
dev 7200 ± 300 1 ± 0 9e-05 ± 4e-05 133 ± 6
Multiprocess wall time [sampling interval: 10]

Multiprocess wall time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 7100 ± 200 0.998 ± 0.001 0.0001 ± 4e-05 136 ± 3
dev 7200 ± 200 0.998 ± 0.001 8e-05 ± 4e-05 130 ± 10
Multiprocess wall time [sampling interval: 100]

Multiprocess wall time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 6600 ± 800 0.02 ± 0.002 4e-05 ± 2e-05 136 ± 6
dev 7100 ± 500 0.02 ± 0.002 5e-05 ± 2e-05 134 ± 8
Multiprocess wall time [sampling interval: 1000]

Multiprocess wall time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 6400 ± 500 0.0014 ± 0.0002 2e-05 ± 2e-05 42 ± 2
dev 6600 ± 100 0.0014 ± 0.0001 2e-05 ± 2e-05 41 ± 1

@P403n1x87 P403n1x87 force-pushed the refactor/remove-exclude-empty branch 2 times, most recently from 1c15ea8 to 62dcd8e Compare March 16, 2024 18:03
The option has been broken for the past few releases and it didn't
seem to cause major issues. So we make the assumption that this option
is not used frequently and therefore we make the decision to drop it.
@P403n1x87 P403n1x87 force-pushed the refactor/remove-exclude-empty branch from 62dcd8e to b2dd9c8 Compare March 16, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant