Add some changes #10
Open
Add some changes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humpalum
reviewed
Jun 23, 2021
| @@ -1,19 +1,26 @@ | |||
| app: 'sigma_hunting_app' | |||
| cron_schedule: '*/10 * * * *' | |||
| earliest_time: '-10m' | |||
| earliest_time: '0' | |||
There was a problem hiding this comment.
Shouldn't you search for the last 10m when you have a cron schedule of every 10m?
There was a problem hiding this comment.
In fact all my searches use indexed time to prevent missing alert if delay are observed on collect
aiden-cyberdefense
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using your code to produce a splunk app, I made some changes focused on analyse.
Briefly, i've modified add_field / add_table part (using sigmac fieldlist output).
Feel free to contact me if you need more details.