Completely remove LLVM cmake files inclusion, cleanup and add typo fixes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Not needed when building with cmake, it can be added again if building with build-script
- We point LLVM_DIR to the build directory for those llvm cmake files.
- SWIFT_TARGET_ARCH cannot be used since the arch in the sysroot may likely be different. - Looks like pointing to `-oe-linux` was another typo as well in swift.bbclass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift-stdlib. Instead we checkout swiftlang/llvm-project on the given Swift tag, configure it, and point LLVM_DIR to where the LLVM cmake files are generated in the build directory.do_fix_gcc_install_dir()methods:TARGET_ARCHshould be used instead ofSWIFT_TARGET_ARCH, since we are attempting to fix a symlink in the sysroot, which uses theTARGET_ARCHname.-oe-linuxinstead of${TARGET_VENDOR}-${TARGET_OS}in one of the fix methods. I assume that was just a typo/missed.@lhoward would you do me a favor and see if these changes compile for you? I was able to compile everything except swift-testing/swift-xctest due to an error with the SSH_AUTH_SOCK stuff. Not sure if I'm simply missing some sort of env variable or something, but I also think that the recipe should work even if that is not set. Anyway, here are the logs I'm getting:
Also, @xavgru12 @jeremy-prater so you can see the activity