Add tests for ABX VPP plugin #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrej-fabry
requested changes
Aug 16, 2022
pt-maros
reviewed
Aug 16, 2022
Contributor
There was a problem hiding this comment.
Would it be relevant to add a test for ACL rule with IPv6 prefix? Or a negative scenario when the packet doesn't get forwarded?
Nothing else comes to my mind when it comes to test scenarios. Beyond that, I noticed that the test file fails style check when v22.02 VPP branch is checked out. It passes it on master VPP branch. Not sure if that's relevant, perhaps for some automated test in build service.
Signed-off-by: Vladimir Bernolak <vladimir.bernolak@pantheon.tech>
PantheonVladimirB
force-pushed
the
add_abx_tests
branch
from
36e4ee3 to
bda1d02
Compare
ondrej-fabry
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vladimir Bernolak vladimir.bernolak@pantheon.tech