Conversation
Closed
3 tasks
sonms
approved these changes
Jan 28, 2026
Member
sonms
left a comment
There was a problem hiding this comment.
너무 고생많으셨습니다!
궁금한 점이 있어 여기에 남깁니다!
-
가끔 onClick이랑 onValueChanged 가 빠진 부분이 있는데 필요하지 않아서 구현하지 않고 {}만 남기신 건지 아니면 추후 API 붙이실 때 반영하실 예정인지 궁금합니다!
-
파라미터로 전달되는 변수들 역시 state로 묶어서 관리할 수 있을 것 같은데 나중에 확인 부탁드려용
app/src/main/java/com/paw/key/presentation/ui/mypage/courseinfo/CourseInfoScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/paw/key/presentation/ui/mypage/courseinfo/component/CourseRouteItem.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/paw/key/presentation/ui/mypage/courseinfo/component/CourseRouteItem.kt
Show resolved
Hide resolved
...c/main/java/com/paw/key/presentation/ui/mypage/courseinfo/navigation/CourseInfoNavigation.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/paw/key/presentation/ui/mypage/main/component/PetCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/paw/key/presentation/ui/mypage/petinfo/PetProfileListScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/paw/key/presentation/ui/mypage/petinfo/PetProfileListScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/paw/key/presentation/ui/mypage/petinfo/PetProfileScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/paw/key/presentation/ui/mypage/userinfo/component/UserProfileItem.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+19
to
+63
| @Composable | ||
| fun UserGenderButton( | ||
| user: String, | ||
| isSelect: Boolean, | ||
| onClick: () -> Unit, | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| Box( | ||
| contentAlignment = Alignment.Center, | ||
| modifier = modifier | ||
| .clip(RoundedCornerShape(8.dp)) | ||
| .background( | ||
| color = if (isSelect) { | ||
| PawKeyTheme.colors.primary | ||
| } else { | ||
| PawKeyTheme.colors.background | ||
| } | ||
| ) | ||
| .border( | ||
| width = 1.dp, | ||
| color = if (isSelect) { | ||
| Color.Transparent | ||
| } else { | ||
| PawKeyTheme.colors.defaultMiddle | ||
| }, | ||
| shape = RoundedCornerShape(8.dp) | ||
| ) | ||
| .noRippleClickable(onClick) | ||
| .padding(horizontal = 68.dp, vertical = 16.dp) | ||
| ) { | ||
| Text( | ||
| text = user, | ||
| color = if (isSelect) { | ||
| PawKeyTheme.colors.background | ||
| } else { | ||
| PawKeyTheme.colors.defaultMiddle | ||
| }, | ||
| style = if (isSelect) { | ||
| PawKeyTheme.typography.bodyActive | ||
| } else { | ||
| PawKeyTheme.typography.bodyDefault | ||
| }, | ||
| ) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
val backgroundColor = if (isSelect) PawKeyTheme.colors.primary else PawKeyTheme.colors.background
val borderColor = if (isSelect) Color.Transparent else PawKeyTheme.colors.defaultMiddle
val contentColor = if (isSelect) PawKeyTheme.colors.background else PawKeyTheme.colors.defaultMiddle
val textStyle = if (isSelect) PawKeyTheme.typography.bodyActive else PawKeyTheme.typography.bodyDefault
Box(
contentAlignment = Alignment.Center,
modifier = modifier
.clip(shape)
.background(color = backgroundColor)
.border(
width = 1.dp,
color = borderColor,
shape = shape
)
.noRippleClickable(onClick)
.padding(horizontal = 68.dp, vertical = 16.dp)
) {
Text(
text = user,
color = contentColor,
style = textStyle
)
}이거도 묶으면 좋을 것 같은데 어떻게 생각하시나ㅓ요?
지금도 사실 보기에 나쁘지는 않아요
Member
Author
API 연동 시점에 Click 관련 메서드 반영하겠습니다! 추가 수정된 뷰쪽에도 클릭 이벤트 발생시 변화는 화면에 대해 안올라온게 있어서 좀 헷갈리더라구요 ㅜㅜ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE
❗ WORK DESCRIPTION
📢 TO REVIEWERS
📸 SCREENSHOT
-.Clipchamp.10.mp4