Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud feedbacks: updates to code backend #1100

Merged
merged 16 commits into from
Aug 26, 2024
Merged

Conversation

mzelinka
Copy link
Collaborator

several lines in lib/cal_CloudRadKernel_xr.py were updated to be compatible with the latest version of xCDAT

@lee1043 lee1043 self-requested a review May 31, 2024 23:37
@lee1043 lee1043 added the bug label May 31, 2024
@lee1043 lee1043 changed the title updates to code backend Cloud feedbacks: updates to code backend Jun 1, 2024
@lee1043 lee1043 added this to the 3.4.2 milestone Jun 1, 2024
@lee1043
Copy link
Contributor

lee1043 commented Jun 2, 2024

Progress note: code is ready for merge after the final test -- check for any changes in the metrics due to change of landmask generation. It used to use the global_land_mask that is installable via only pip, now switched to PMP's create_land_sea_mask function.

@lee1043 lee1043 modified the milestones: 3.4.2, 3.5.1 Jun 23, 2024
@lee1043
Copy link
Contributor

lee1043 commented Aug 26, 2024

Output JSON checked, no noticeable difference was found.

@lee1043 lee1043 merged commit cff4e61 into main Aug 26, 2024
5 checks passed
@lee1043 lee1043 deleted the 979_cloudfeedback_xcdat branch August 26, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants