Propose a change for floating number format for mean climate metrics … #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…output Current compute_metrics.py used either ".5f" or ".3f" to form the floating numbers for the output from the mean climate driver. As the magnitude of the model variable can range from 1e5 (e.g pressure ) to 1e-3 (e.g. humidity), used the ".5f" and ".3f" can sometimes truncate the small values to zero. It seems that using a standard scientific notation can be benificial in case the user processed the data without converting the unit data ahead. In this way, it also provide possibilities for users to convert the units within the diagnostic datasets.
|
An example can be seen in the PMP metrics data for zonal wind stress (tauv) below: You can see that the biases in many metrics results are zeros ,while the mean values of this variable are around 10^{-2}. I think for this scenario, 3 digt decimal points for biases are not enough to provide useful information. |
lee1043
approved these changes
Oct 8, 2024
|
@zhangshixuan1987 thank you for the PR. I am merging it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current compute_metrics.py used either ".5f" or ".3f" to form the floating numbers for the output from the mean climate driver. As the magnitude of the model variable can range from 1e5 (e.g. pressure ) to 1e-3 (e.g. humidity), using the ".5f" and ".3f" can sometimes truncate the small values to zero. It seems that using a standard scientific notation can be beneficial if the user processes the data without converting the unit data ahead. In this way, it also provides possibilities for users to convert the units within the diagnostic datasets.
I submit this pull request to trigger some discussions and see if a better solution can be made to the PMP master code.