Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off github action for draft PRs #1160

Merged
merged 8 commits into from
Oct 22, 2024
Merged

Turn off github action for draft PRs #1160

merged 8 commits into from
Oct 22, 2024

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Oct 17, 2024

@lee1043 lee1043 requested a review from tomvothecoder October 17, 2024 07:42
@lee1043 lee1043 marked this pull request as ready for review October 17, 2024 07:42
@lee1043
Copy link
Contributor Author

lee1043 commented Oct 17, 2024

@tomvothecoder when you have time, would you be able to help reviewing this? I am trying to turn off github action when PR is draft mode.

@lee1043 lee1043 self-assigned this Oct 17, 2024
@lee1043 lee1043 added the build label Oct 17, 2024
Copy link
Collaborator

@tomvothecoder tomvothecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check if the build is correctly ignored by marking this PR as draft. Afterwards, you can mark it as "Ready for Review" to see if it runs.

The code changes seem correct to me.

@lee1043 lee1043 marked this pull request as draft October 21, 2024 19:51
@lee1043 lee1043 marked this pull request as ready for review October 21, 2024 20:25
@lee1043 lee1043 marked this pull request as draft October 21, 2024 20:38
@lee1043
Copy link
Contributor Author

lee1043 commented Oct 21, 2024

@tomvothecoder thank you for the great advice! That was very helpful!

@lee1043 lee1043 marked this pull request as ready for review October 22, 2024 21:39
@lee1043 lee1043 marked this pull request as draft October 22, 2024 21:43
@lee1043 lee1043 marked this pull request as ready for review October 22, 2024 21:45
@lee1043
Copy link
Contributor Author

lee1043 commented Oct 22, 2024

@lee1043 lee1043 linked an issue Oct 22, 2024 that may be closed by this pull request
@lee1043 lee1043 merged commit 6a5c9f5 into main Oct 22, 2024
4 checks passed
@lee1043 lee1043 deleted the lee1043-patch-1 branch October 22, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Reduce CI run by turn off github action for draft PR
2 participants