Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version handling #1192

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Version handling #1192

merged 8 commits into from
Nov 18, 2024

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Nov 18, 2024

To address #1191

@lee1043 lee1043 added the bug label Nov 18, 2024
@lee1043 lee1043 self-assigned this Nov 18, 2024
@lee1043 lee1043 requested a review from acordonez November 18, 2024 23:33
@lee1043 lee1043 marked this pull request as ready for review November 18, 2024 23:34
@lee1043
Copy link
Contributor Author

lee1043 commented Nov 18, 2024

@acordonez could you check if this addresses the issue you reported?

@acordonez
Copy link
Collaborator

Thanks! I will test this today

@acordonez
Copy link
Collaborator

@lee1043 This fixed the bug for me. Thanks again.

@lee1043
Copy link
Contributor Author

lee1043 commented Nov 18, 2024

@acordonez nice, thanks for promptly checking this!

@lee1043 lee1043 merged commit 6aba95b into main Nov 18, 2024
4 checks passed
@lee1043 lee1043 deleted the lee1043-patch-1 branch November 18, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AttributeError: module 'pcmdi_metrics' has no attribute 'version'
2 participants