Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL in graphics notebooks #839

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Update URL in graphics notebooks #839

merged 2 commits into from
Apr 12, 2022

Conversation

acordonez
Copy link
Collaborator

I updated the URL to the raw JSON files in the portrait plot and parallel coordinate plot notebooks, and reran the notebooks. I visually compared the figures with those in the "main" branch and they appear to match.

@@ -208,7 +208,7 @@
"var_list: ['pr', 'prw', 'psl', 'rlds', 'rltcre', 'rlus', 'rlut', 'rlutcs', 'rsds', 'rsdscs', 'rsdt', 'rstcre', 'rsut', 'rsutcs', 'sfcWind', 'ta-200', 'ta-850', 'tas', 'tauu', 'ts', 'ua-200', 'ua-850', 'va-200', 'va-850', 'zg-500']\n",
"var_unit_list: ['pr [N/A]', 'prw [N/A]', 'psl [N/A]', 'rlds [N/A]', 'rltcre [W m-2]', 'rlus [N/A]', 'rlut [N/A]', 'rlutcs [N/A]', 'rsds [N/A]', 'rsdscs [N/A]', 'rsdt [N/A]', 'rstcre [W m-2]', 'rsut [N/A]', 'rsutcs [N/A]', 'sfcWind [N/A]', 'ta-200 [N/A]', 'ta-850 [N/A]', 'tas [N/A]', 'tauu [N/A]', 'ts [N/A]', 'ua-200 [N/A]', 'ua-850 [N/A]', 'va-200 [N/A]', 'va-850 [N/A]', 'zg-500 [N/A]']\n",
"len(var_list: 25\n",
"regions: ['NHEX_ocean', 'NHEX', 'SHEX_ocean', 'global', 'ocean', 'ocean_50S50N', 'NHEX_land', 'land', 'SHEX', 'TROPICS', 'SHEX_land']\n",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of the regions was scrambled between notebooks, but the same regions are present in each of them.

@acordonez acordonez requested a review from lee1043 April 12, 2022 19:07
@lee1043
Copy link
Contributor

lee1043 commented Apr 12, 2022

@acordonez thank you for the update. I am merging this PR.

@lee1043 lee1043 merged commit c3105c8 into main Apr 12, 2022
@lee1043 lee1043 deleted the ao_update_link branch April 12, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants