-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test clang with and without optimisations #559
Conversation
The build failure here is due to #558 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be better to implement this test as part of another job that might also test other things in parallel that aren''t currently covered.
for example as part of a windows build that uses the alternative clang compiler that comes with Visual Studio and that might be updated in the future to build for ARM64
41c8860
to
b6a00d5
Compare
Please update this patch to master. |
b6a00d5
to
de85b6a
Compare
Grr, there's still a build problem, even after your fix. I'll try and work it out as quick as possible. It may be that running |
yes, whichs is why I suggested doing it on windows instead (without. the sanitize part, of course) |
c7a2908
to
cc806de
Compare
@zherczeg I've fixed it; the next build should pass, and will be OK to merge. |
Ok. Lets wait the CI then. |
No description provided.