Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test clang with and without optimisations #559

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

NWilson
Copy link
Contributor

@NWilson NWilson commented Nov 11, 2024

No description provided.

@NWilson
Copy link
Contributor Author

NWilson commented Nov 11, 2024

The build failure here is due to #558

Copy link
Contributor

@carenas carenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be better to implement this test as part of another job that might also test other things in parallel that aren''t currently covered.

for example as part of a windows build that uses the alternative clang compiler that comes with Visual Studio and that might be updated in the future to build for ARM64

.github/workflows/dev.yml Outdated Show resolved Hide resolved
@zherczeg
Copy link
Collaborator

Please update this patch to master.
After it is landed, the next step for me is #553

@NWilson
Copy link
Contributor Author

NWilson commented Nov 15, 2024

Grr, there's still a build problem, even after your fix. I'll try and work it out as quick as possible.

It may be that running clang -fsanitize -O0 simply isn't sensible.

@carenas
Copy link
Contributor

carenas commented Nov 15, 2024

It may be that running clang -fsanitize -O0 simply isn't sensible

yes, whichs is why I suggested doing it on windows instead (without. the sanitize part, of course)

@NWilson
Copy link
Contributor Author

NWilson commented Nov 15, 2024

@zherczeg I've fixed it; the next build should pass, and will be OK to merge.

@zherczeg
Copy link
Collaborator

Ok. Lets wait the CI then.

@zherczeg zherczeg merged commit b65cf00 into PCRE2Project:master Nov 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants