Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Generators proof of concept #60

Closed
wants to merge 3 commits into from

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Apr 17, 2019

Purpose of this PR is to introduce generators, maintaining backward compatibility with current usage expecting Promises if possible.

At the time of initial PR, it simply creates a generator function which is immediately wrapped around with promisify-generator and does not really change the behaviour, slightly increasing memory footprint.

To maintain compatibility with node 6.x code will probably need to be transpiled via babel.

@AlexZeitler
Copy link
Contributor

Will look into it later this evening

@AlexZeitler
Copy link
Contributor

AlexZeitler commented Apr 17, 2019

Speaking of transpiling: I was already thinking about refactoring the source towards TypeScript - what do think about that?

@Steveb-p
Copy link
Contributor Author

Speaking of transpiling: I was already thinking about refactoring the source towards TypeScript - what do think about that?

I don't mind, though I'm not well versed in TypeScript specifics. But there doesn't seem much code that uses advanced TypeScript here and we can always migrate incrementally I guess.

@frank-dspeed
Copy link

i have a Already working Implamentation of a docker-compose interactive version that uses most streams it allows to run interactive sessions as also supports log follow and other stuff

it is also implamented as a class so that you don't need to always set cwd and that @Steveb-p @AlexZeitler

@Steveb-p
Copy link
Contributor Author

I'll rewrite this completely.

@Steveb-p Steveb-p closed this Jul 24, 2019
@Steveb-p Steveb-p deleted the generators-proof-of-concept branch July 24, 2019 07:33
@AlexZeitler
Copy link
Contributor

@Steveb-p Looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants