Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 30 #14

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Release 30 #14

merged 5 commits into from
Apr 11, 2024

Conversation

WouterVisscher
Copy link
Contributor

@WouterVisscher WouterVisscher commented Apr 10, 2024 •
edited
Loading

Omschrijving

Voorbereiding 30.0.0 release.
Met de jaxb -> jakarta migratie

Type verandering

Checklist:

  • Ik heb de code in deze PR zelf nogmaals nagekeken
  • Ik heb mijn code beter achtergelaten dan dat ik het aantrof
  • De code is leesbaar en de moeilijke onderdelen zijn voorzien van commentaar
  • Ik heb de tests toegevoegd/uitgebreid indien nodig
  • Ik heb de tests gedraaid die de werking van mijn wijziging bewijst
  • Er zit geen gevoelig informatie in deze PR (wachtwoorden etc)

roelarents
roelarents approved these changes Apr 11, 2024
View reviewed changes
Copy link

@roelarents roelarents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

roelarents
roelarents reviewed Apr 11, 2024
View reviewed changes
src/main/java/nl/pdok/gml3/exceptions/GML3ParseException.java Outdated
* To change this license header, choose License Headers in Project Properties.
* To change this template file, choose Tools | Templates
* and open the template in the editor.
* To change this license header, choose License Headers in Project Properties. To change this
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dit kan nog weg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@WouterVisscher WouterVisscher merged commit 264271d into master Apr 11, 2024
@WouterVisscher WouterVisscher deleted the release-30 branch April 11, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roelarents roelarents roelarents approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WouterVisscher @roelarents