Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add search endpoint #12

Merged
merged 41 commits into from
Dec 23, 2024
Merged

feat: add search endpoint #12

merged 41 commits into from
Dec 23, 2024

Conversation

rkettelerij
Copy link
Collaborator

@rkettelerij rkettelerij commented Nov 29, 2024 •
edited
Loading

Description

Implement search/suggest endpoint

Type of change

  • New feature

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

@rkettelerij rkettelerij force-pushed the search-suggest-endpoint branch from 0be3d2d to 927cd70 Compare December 4, 2024 12:04
@rkettelerij rkettelerij changed the title feat: add search, implement autosuggest endpoint feat: add search endpoint Dec 4, 2024
@rkettelerij
feat: add search endpoint - make args with defaults optional
5598b60
@rkettelerij
feat: add search endpoint - return more columns in select in orde to …
1ec613b 
…build up GeoJSON response
@rkettelerij
feat: add search endpoint - weird test failure, fixing
6d3da80
@rkettelerij
feat: add search endpoint - return GeoJSON response
100655f
@rkettelerij
Merge branch 'master' into search-suggest-endpoint
d5a83cc 
# Conflicts:
#	internal/etl/etl.go
@rkettelerij
feat: add search endpoint - sync with master
a06da94
@rkettelerij
feat: add search endpoint - linting
09fd6ac
@rkettelerij
feat: add search endpoint - add numberReturned
50ec5ee
@rkettelerij
feat: add search endpoint - add href to allow users to get the actual…
b0c3ab4 
… features from the OGC API
@rkettelerij
feat: add search endpoint - add self link (alternate links to HTML/JS…
927f96e 
…ON-FG can be added in the future). ALso changed endpoint to just 'search' in line with OGC API Features part 9 Test Search (early draft)
@rkettelerij
feat: add search endpoint - highlight display name, not suggest
4faae30
@rkettelerij
Merge branch 'master' into search-suggest-endpoint
2e36235 
# Conflicts:
#	cmd/main.go
@rkettelerij
feat: add search endpoint - merge
5c923f4
@rkettelerij
feat: add search endpoint - linting
f5805c9
@rkettelerij
feat: add search endpoint - refactor magic strings to constants + spl…
6806f81 
…it method
@rkettelerij
feat: add search endpoint - use prepared statement for query term
5b4fefc
@rkettelerij
feat: add search endpoint - search in specific collection
06879d2
@rkettelerij
feat: add search endpoint - make collections parameter(s) required
b98f265
@rkettelerij
feat: add search endpoint - remove log
2c48234
@rkettelerij
feat: add search endpoint - remove log
5b3315c
@rkettelerij
feat: add search endpoint - move funcs in line with GoKoala
95ebdd3
@rkettelerij
feat: add search endpoint - move consts to url.go
d8311ca
@rkettelerij
feat: add search endpoint - require collection version in requests
876f778
@rkettelerij
feat: add search endpoint - refactoring + add extra tst with differen…
dcf0d5c 
…t CRS
@rkettelerij
feat: add search endpoint - add order by in subquery + naming
dbe21fe
@rkettelerij
Merge branch 'master' into search-suggest-endpoint
aa58e77
@rkettelerij
feat: add search endpoint - merge master
c2572e0
@rkettelerij
feat: add search endpoint - fix test
1cdb9ea
@rkettelerij
feat: add search endpoint - use collection_id + collection_version as…
1ebd5c8 
… tuples in where clause, instead of individually + add extra tests.
@rkettelerij
feat: add search endpoint - fix test
00e0399
@rkettelerij
feat: add search endpoint - fix test
f36887e
@rkettelerij
feat: add search endpoint - fix tests, multiple changes:
8be5610 
- group by more fields to prevent dups
- optimize performance by executing ts_query once
- include housenr in testdata
- covert all fields used in suggestions to strings since the suggestion field in the index is always text/string.
@rkettelerij
feat: add search endpoint - add OpenAPI spec
d6d2f01
@rkettelerij
feat: add search endpoint - add OpenAPI spec, with all params
71fa65e
@rkettelerij
feat: add search endpoint - remove e2e test for search, already cover…
5724870 
…ed in integration test
@rkettelerij rkettelerij marked this pull request as ready for review December 23, 2024 10:59
@rkettelerij rkettelerij merged commit 8123787 into master Dec 23, 2024
2 checks passed
@rkettelerij rkettelerij deleted the search-suggest-endpoint branch December 23, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerdos82 gerdos82 gerdos82 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkettelerij @gerdos82