Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OOM #25

Merged
merged 4 commits into from
Jan 10, 2025
Merged

fix: OOM #25

merged 4 commits into from
Jan 10, 2025

Conversation

rkettelerij
Copy link
Collaborator

@rkettelerij rkettelerij commented Jan 9, 2025 •
edited
Loading

Description

See commits

Type of change

  • Bugfix

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

@rkettelerij rkettelerij changed the title fix: read CSV files once, not in loop for every BATCH of records fix: OOM Jan 9, 2025
@rkettelerij rkettelerij marked this pull request as ready for review January 9, 2025 15:37
@rkettelerij rkettelerij merged commit e297505 into master Jan 10, 2025
2 checks passed
@rkettelerij rkettelerij deleted the fix-oom branch January 10, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kad-dirc kad-dirc kad-dirc approved these changes

@gerdos82 gerdos82 gerdos82 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkettelerij @gerdos82 @kad-dirc